Skip to content

實質改題三題加 rev:2,使已遷移的舊答案失效(PR #23 Copilot 留言跟進) - #24

Merged
doggy8088 merged 2 commits into
zh-twfrom
fix/copilot-pr23-rev
Nov 10, 2026
Merged

doggy8088 merged 2 commits into
zh-twfrom
fix/copilot-pr23-rev

Conversation

@doggy8088

Copy link
Copy Markdown
Owner

跟進 PR #23 的 Copilot review 留言(https://github.com/doggy8088/HowToLiveBetter/pull/23#discussion_r4523376378,中嚴重度),查證屬實:

PR #19 的遷移程式會在頁面載入時把讀者舊 key 的答案搬到新 key、刪舊 key 並存回 localStorage;PR #23 只從對照表移除三組映射,擋得住未來的遷移,但擋不住 PR #19 合併到 PR #23 合併之間那幾小時內、已經被遷移過的答案。那些讀者的自查頁仍會把三個未經確認的新動作計為已完成。

修正(只改管線層 scripts/zh-tw/convert.mjs,由管線重產;qid() 已支援 rev 後綴,上游 B 型肝炎題已有 rev:2 前例):

  • 13:濃煙關門、5:綜合所得稅結算申報、5:眷屬依附加保三題加 rev:2,qid 產生 :v2 新 key,舊答案失效、讀者只需重答這三題。
  • 其餘四組同義映射(乙醯胺酚、瓦斯軟管、不把銀行帳戶、聯徵信用報告)不受影響,答案保留。

驗證:

  • 自上游 dff814d 完整重產,七道閘門全綠;重產樹與本分支差異僅 selfcheck.html(三行加 rev:2)。
  • 抽出頁面主程式 node --check 通過;實測:空窗期已遷移的三題答案在 :v2 下讀不到(undefined,需重答),同義映射的答案仍正常讀取(乙醯胺酚 y、不把銀行帳戶 n、瓦斯軟管 y)。

Assisted-by: Muse

PR #19 的遷移曾在空窗期把舊答案搬到新 key 並存回;PR #23
只移除對照表映射,擋不住已遷移的答案。給火災、稅務、健保
三題加 rev:2,qid() 產生 :v2 新 key,舊答案失效、讀者只需
重答這三題;其餘四組同義映射的答案不受影響。

Assisted-by: Muse
PR #19 的遷移曾在空窗期把舊答案搬到新 key 並存回;PR #23
只移除對照表映射,擋不住已遷移的答案。給火災、稅務、健保
三題加 rev:2,qid() 產生 :v2 新 key,舊答案失效、讀者只需
重答這三題;其餘四組同義映射的答案不受影響。

Assisted-by: Muse
Copilot AI balanced review requested due to automatic review settings November 10, 2026 12:46
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T12:47:02.607521Z
We couldn’t complete this review. Comment @codex review to try again.
35856cb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@doggy8088
doggy8088 merged commit e7d05db into zh-tw Nov 10, 2026
7 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the changes requiring readers to answer the three revised questions again.

No open issues 🎉

What changed in this PR

延續 PR #23 的修正,讓 PR #19 空窗期內已遷移的三題舊答案失效,避免未經確認的新動作被計為已完成。

變更:

  • 為濃煙關門、綜合所得稅結算申報、眷屬依附加保三題加入 rev:2,使用新的 :v2 答案識別碼,要求讀者重新回答。
  • 在轉換管線加入對應規則,確保重產保留修正;其餘四組同義改名的答案遷移不變。
File Description
selfcheck.html 三題加入 rev:2,不再沿用舊識別碼下的答案。
scripts/​zh-tw/​convert.mjs 加入三題版本更新的轉換規則及原因註解。

Review effort: Balanced

@doggy8088
doggy8088 deleted the fix/copilot-pr23-rev branch November 10, 2026 12:50
SanHsien added a commit to SanHsien/HowToLiveBetter that referenced this pull request Nov 13, 2026
…a3752d

Glossary: the body text already uses Taiwan wording, so the README
glossary drops the old-term aliases and index.html follows.

Direct upstream doggy8088 81e167a..1a3752d (7 commits, PR doggy8088#24): adopts
the rev:2 bump that invalidates migrated answers for three changed
questions, the convert-pipeline protections, the offline skill zip builder
(tools/skill/build.mjs, keeping this fork's text, source URL and
licences) and the legal-text conversion rule; Taiwan's legal and
institutional wording stays. Root upstream eternity4719 36c7856 is covered
by 00c9919; issue eternity4719#176 is recorded but not adopted until the book covers it.

The zh-TW locale check now also rejects 聯網, 會話, 壓縮包 and MIT 許可,
and convert.mjs keeps the Taiwan wording of two selfcheck hints.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants